Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: divde by zero for decom status #4908

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Apr 22, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

package main

import "fmt"

func main() {
	usedCurrent := 0
	totalSize := 0
	capacity := fmt.Sprintf("%.1f%% (total: 0B)", 100*float64(usedCurrent)/float64(totalSize))
	fmt.Println(capacity)
}

shows

NaN% (total: 0B)

fix minio/minio#19545

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the underlying problem should also be fixed.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 5b7b222 into minio:master Apr 29, 2024
7 checks passed
@harshavardhana
Copy link
Member

Though the underlying problem should also be fixed.

yeah the underlying problem is fixed in the minio master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First pool with minimal HA shows mc admin decommission status shows NaN
5 participants