Add server side encryption support #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Dec 7, 2018
poornas
force-pushed
the
encrypt
branch
3 times, most recently
from
5bda1e1
to
d71355b
Compare
|
@harshavardhana , review comments were fixed.PTAL |
harshavardhana
approved these changes
Dec 13, 2018
kannappanr
reviewed
Dec 14, 2018
kannappanr
requested changes
Dec 14, 2018
kannappanr
reviewed
Dec 15, 2018
kannappanr
reviewed
Dec 16, 2018
kannappanr
reviewed
Dec 16, 2018
harshavardhana
requested changes
Dec 17, 2018
|
@harshavardhana, updated the example in minio.examples to api.md as well. |
|
rebased to master. PTAL @kannappanr && @harshavardhana |
poornas
force-pushed
the
encrypt
branch
2 times, most recently
from
200dc44
to
3b5e0dd
Compare
|
@harshavardhana and @kannappanr, PTAL |
harshavardhana
approved these changes
Jan 3, 2019
kannappanr
requested changes
Jan 3, 2019
| @@ -0,0 +1,166 @@ | |||
| /* | |||
| * Minio .NET Library for Amazon S3 Compatible Cloud Storage, (C) 2017 Minio, Inc. | |||
| /// <param name="cancellationToken">Optional cancellation token to cancel the operation</param> | ||
| Task GetObjectAsync(string bucketName, string objectName, long offset, long length, Action<Stream> cb, CancellationToken cancellationToken = default(CancellationToken)); | ||
| Task GetObjectAsync(string bucketName, string objectName, long offset, long length, Action<Stream> cb, ServerSideEncryption sse = null,CancellationToken cancellationToken = default(CancellationToken)); |
There was a problem hiding this comment.
need space between ServerSideEncryption sse = null,CancellationToken
| /// <param name="cancellationToken">Optional cancellation token to cancel the operation</param> | ||
| Task GetObjectAsync(string bucketName, string objectName, Action<Stream> callback, CancellationToken cancellationToken = default(CancellationToken)); | ||
| Task GetObjectAsync(string bucketName, string objectName, Action<Stream> callback, ServerSideEncryption sse = null,CancellationToken cancellationToken = default(CancellationToken)); |
There was a problem hiding this comment.
need space between ServerSideEncryption sse = null,CancellationToken
| EncryptedCopyObject_Test1(minioClient).Wait(); | ||
| EncryptedCopyObject_Test2(minioClient).Wait(); | ||
|
|
||
| // Uncommment these tests when Mint supports Vault/KMS |
There was a problem hiding this comment.
Can we use an environment variable here which can also be used in Mint, instead of commenting out this piece of code?
| /// <param name="cancellationToken">Optional cancellation token to cancel the operation</param> | ||
| public async Task GetObjectAsync(string bucketName, string objectName, Action<Stream> cb, CancellationToken cancellationToken = default(CancellationToken)) | ||
| public async Task GetObjectAsync(string bucketName, string objectName, Action<Stream> cb, ServerSideEncryption sse = null,CancellationToken cancellationToken = default(CancellationToken)) |
There was a problem hiding this comment.
need space between ServerSideEncryption sse = null,CancellationToken
| /// <param name="cancellationToken">Optional cancellation token to cancel the operation</param> | ||
| /// <returns>Facts about the object</returns> | ||
| public async Task<ObjectStat> StatObjectAsync(string bucketName, string objectName, CancellationToken cancellationToken = default(CancellationToken)) | ||
| public async Task<ObjectStat> StatObjectAsync(string bucketName, string objectName, ServerSideEncryption sse = null,CancellationToken cancellationToken = default(CancellationToken)) |
There was a problem hiding this comment.
Need space here ServerSideEncryption sse = null,CancellationToken
|
@kannappanr, incorporated your feedback. |
harshavardhana
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251