Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend V4Authenticator constructor to take region #265

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Extend V4Authenticator constructor to take region #265

merged 1 commit into from
Dec 27, 2018

Conversation

krisis
Copy link
Member

@krisis krisis commented Dec 27, 2018

Fixes #264

kannappanr
kannappanr approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana removed the request for review from poornas December 27, 2018 16:31
@nitisht nitisht merged commit 64bf0b4 into minio:master Dec 27, 2018
@AdmirR
Copy link

AdmirR commented Dec 28, 2018

One small change still required, see #264

@krisis krisis deleted the issue/264 branch December 29, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krisis @AdmirR @harshavardhana @kannappanr @nitisht