Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTP Proxy to be configured #276

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Allow HTTP Proxy to be configured #276

merged 1 commit into from
Jan 28, 2019

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jan 18, 2019

fixes #273

@krisis
Copy link
Member

krisis commented Jan 24, 2019

@poornas,

  1. Why are we not adding a new (overloaded) constructor which takes the proxy as a parameter?
    If it is exposed as a member of MinioClient object, isn't it susceptible to data race like proxy being modified while a PutObject of a large object is ongoing? i.e UploadPart API calls may be sent over the proxy while the CompleteMultipartUpload may be sent over the updated proxy. This causes unnecessary confusion.
  2. We should update the README with a section describing how and when to use the proxy setting in MinioClient.

@poornas
Copy link
Contributor Author

poornas commented Jan 25, 2019

@krisis, Proxy is set only once during initialization of the underlying RestSharp client, and hence the data race scenario you stated above will not arise. This doesn't have to be added to README imo, because it is not per se a minio-dotnet sdk feature.

@krisis
Copy link
Member

krisis commented Jan 25, 2019

@poornas, I understand why there won't be any data race like I thought earlier. Thanks for clarifying that. Won't it help our users if we added an example that demonstrates how and when to set proxy client?

@poornas
Copy link
Contributor Author

poornas commented Jan 27, 2019

@krisis, added an example and changed it to a chained constructor.

Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Copy link

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit db8313d into minio:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Proxy support
4 participants