Fix observable to honor dispose #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolfspiritM
force-pushed
the
fix-observable
branch
from
b632031
to
5fcfd71
Compare
krisis
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you Subscribe to a ListObjectsAsync right now there is no way to cancel it before completion (except for using a cancelationtoken). Dispose on the resulting ISubscription is ignored.
For big storages this is an issue as it keeps polling the minio server without any reason in the background and new requests just add to it resulting in spamming the API.
This PR causes the requests to stop once the Subscription gets disposed.