Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deadlock by adding ConfigureAwait(false) #333

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Aug 30, 2019

Fixes #325 - A couple of calls are still passing caller context
to continuation tasks - add ConfigureAwait(false) to disallow
continuation after await from running in caller context.

Fixes minio#325 - A couple of calls are still passing caller context
to continuation tasks - add ConfigureAwait(false) to disallow
continuation after await from running in caller context.
Copy link
Contributor

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 962e3b3 into minio:master Sep 3, 2019
@poornas poornas deleted the await branch September 3, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlocks due to ConfigureAwait(false) not used in ExecuteTaskAsync method
4 participants