Unescape URI encoded returns in listObjectsResult #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
make-sure
branch
from
a96093f
to
1672c66
Compare
harshavardhana
changed the title
|
@harshavardhana do you have a test case to recreate the issue this PR is fixing? Does this problem happen in minio-go too after minio/minio-go#1161? |
Yes and here it is To reproduceThis will hang forever listing first 1000 entries repeatedly. |
harshavardhana
force-pushed
the
make-sure
branch
from
1672c66
to
5773753
Compare
poornas
requested changes
Sep 23, 2019
harshavardhana
force-pushed
the
make-sure
branch
from
5773753
to
5bc14df
Compare
poornas
approved these changes
Sep 23, 2019
8bd4c65 added encoding-type this broke recursive listing for special characters due to wrong marker calculation, this PR fixes this.
harshavardhana
force-pushed
the
make-sure
branch
from
5bc14df
to
7f7a9c7
Compare
krisis
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8bd4c65 added encoding-type
this broke recursive listing for special characters due to
wrong marker calculation, this PR fixes this.