Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-adjusted the progress reporting #955

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

ebozduman
Copy link
Collaborator

Sometimes the build test fails when 100% progress is supposed to be reached at for PutObject_Test9 and PutObject_Test10 tests.
So, the progress code is re-adjusted to address this sporadic issue.
Since I cannot reproduce the problem and hence cannot test the fix in my local environment, it would not be possible to say for sure the issue is addressed even if the build tests pass.

@ebozduman
Copy link
Collaborator Author

@balamurugana , @krisis, @Praveenrajmani, @shtripat, @harshavardhana
Need one review & approval to merge.

shtripat
shtripat previously approved these changes Dec 14, 2023
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment/clarification.

Minio.Functional.Tests/FunctionalTest.cs Show resolved Hide resolved
Minio.Functional.Tests/FunctionalTest.cs Show resolved Hide resolved
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebozduman ebozduman merged commit e7dcf03 into minio:master Dec 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants