Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/s3signer: PreSignV2 is encoding all query params erroneously #825

Closed
harshavardhana opened this issue Sep 26, 2017 · 1 comment
Closed

pkg/s3signer: PreSignV2 is encoding all query params erroneously #825

harshavardhana opened this issue Sep 26, 2017 · 1 comment
Labels
priority: medium
Milestone
Current

Comments

@harshavardhana
Copy link
Member

The subresources that must be included when constructing the CanonicalizedResource Element are acl, lifecycle, location, logging, notification, partNumber, policy, requestPayment, torrent, uploadId, uploads, versionId, versioning, versions, and website.

http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html#RESTAuthenticationQueryStringAuth
@deekoder deekoder added this to the Future milestone Sep 26, 2017
@deekoder
Copy link
Contributor

discussed with @harshavardhana as an item to take care of in the future.

harshavardhana added a commit to harshavardhana/minio-go that referenced this issue Sep 26, 2017
@harshavardhana @minio-trusted
Fix preSign signature calculation to honor resource lists.
8ba8361 
Currenlty we used to sign all the query parameters, this
is not in accordance with AWS S3 spec. We should only
canonicalize query params which are present in resouce list.

Fixes minio#825
@harshavardhana harshavardhana mentioned this issue Sep 26, 2017
Merged
deekoder pushed a commit that referenced this issue Sep 27, 2017
@harshavardhana @deekoder
Fix preSign signature calculation to honor resource lists. (#827)
3d954df 
Currenlty we used to sign all the query parameters, this
is not in accordance with AWS S3 spec. We should only
canonicalize query params which are present in resouce list.

Fixes #825
@harshavardhana harshavardhana modified the milestones: Future, Current Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium
Projects
None yet
Milestone
Current
Development

No branches or pull requests
2 participants
@harshavardhana @deekoder