Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SetBucketEncryption and GetBucketEncryption apis #1217

Merged
merged 2 commits into from Feb 1, 2020
Merged

Adds SetBucketEncryption and GetBucketEncryption apis #1217

merged 2 commits into from Feb 1, 2020

Conversation

ebozduman
Copy link
Contributor

Support for SetBucketEncryption and GetBucketEncryption apis

@ebozduman ebozduman force-pushed the bucket-encryption-apis branch 3 times, most recently from 0c1badc to 722e0ef Compare January 18, 2020 00:44
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 18, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
poornas
poornas requested changes Jan 18, 2020
View reviewed changes
api-get-bucket-encryption.go Outdated Show resolved Hide resolved
harshavardhana
harshavardhana requested changes Jan 18, 2020
View reviewed changes
api-get-bucket-encryption.go Outdated Show resolved Hide resolved
api-put-bucket.go Show resolved Hide resolved
examples/s3/setbucketencryption.go Outdated Show resolved Hide resolved
@ebozduman ebozduman force-pushed the bucket-encryption-apis branch 3 times, most recently from abbce66 to 00abef9 Compare January 21, 2020 02:06
harshavardhana
harshavardhana requested changes Jan 21, 2020
View reviewed changes
api-get-bucket-encryption.go Outdated Show resolved Hide resolved
@ebozduman ebozduman force-pushed the bucket-encryption-apis branch 2 times, most recently from 3589220 to 38a5646 Compare January 22, 2020 19:18
kannappanr
kannappanr reviewed Jan 23, 2020
View reviewed changes
README.md Show resolved Hide resolved
kannappanr
kannappanr reviewed Jan 23, 2020
View reviewed changes
api-put-bucket.go Outdated Show resolved Hide resolved
@ebozduman ebozduman force-pushed the bucket-encryption-apis branch 2 times, most recently from 3d8222f to 41631af Compare January 24, 2020 00:02
harshavardhana
harshavardhana requested changes Jan 26, 2020
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
examples/s3/setbucketencryption.go Show resolved Hide resolved
api-put-bucket.go Outdated Show resolved Hide resolved
api-put-bucket.go Outdated Show resolved Hide resolved
api-put-bucket.go Outdated Show resolved Hide resolved
api-put-bucket.go Outdated Show resolved Hide resolved
api-put-bucket.go Show resolved Hide resolved
api-get-bucket-encryption.go Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member

I see that you have resolved my comments, but they haven't been addressed - are you planning to address them?

@ebozduman
Copy link
Contributor Author

ebozduman commented Jan 28, 2020 •
edited

@harshavardhana
I've resolved and addressed your comments with one exception : introducing the helper functions. I wanted to address that one also to push everything altogether, but then we thought it would be better if we wait for @krisis changes which are almost done.
I'll push the rest of the changes in a minute

@ebozduman
Copy link
Contributor Author

@harshavardhana
Done.

kannappanr
kannappanr approved these changes Feb 1, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit fc1f142 into minio:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas requested changes

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ebozduman @harshavardhana @poornas @kannappanr