fix: make sure getObject returns error on truncated responses #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR also adds tests to handle these cases specially fixes minio#1451
harshavardhana
force-pushed
the
fix-remove
branch
from
6cf836d
to
e5b87e1
Compare
harshavardhana
added a commit
to harshavardhana/minio-go
that referenced
this pull request
Feb 17, 2021
As a continuation of work from minio#1452, when object sizes are bigger, we should calculate totalRead and match with expected object size. fixes minio#1451
harshavardhana
added a commit
that referenced
this pull request
Feb 18, 2021
This was referenced Mar 15, 2021
Merged
MichaelEischer
added a commit
to MichaelEischer/restic
that referenced
this pull request
Jul 10, 2021
Possibly interesting changes: Azure/azure-sdk-for-go#14521 Retry on HTTP client errors minio/minio-go#1452 fix: make sure getObject returns error on truncated responses golang/net@f585440 http2: close Transport connection on write errors
6 tasks
mfrischknecht
pushed a commit
to mfrischknecht/restic
that referenced
this pull request
Jun 14, 2022
Possibly interesting changes: Azure/azure-sdk-for-go#14521 Retry on HTTP client errors minio/minio-go#1452 fix: make sure getObject returns error on truncated responses golang/net@f585440 http2: close Transport connection on write errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR also adds tests to handle these cases specially
fixes #1451