Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IMDS Version 2. #1489

Merged
merged 2 commits into from Jun 2, 2021

Conversation

michaelfoley1
Copy link
Contributor

@klauspost
Copy link
Contributor

@michaelfoley1 Please check these linter/vet checks:

Running lint check
Error: pkg/credentials/iam_aws.go:62: File is not `goimports`-ed (goimports)
	tokenRequestTTLHeader = "X-aws-ec2-metadata-token-ttl-seconds"
	tokenPath             = "/latest/api/token"
	tokenTTL              = "21600"
	tokenRequestHeader    = "X-aws-ec2-metadata-token"
Error: pkg/credentials/iam_aws.go:263:8: ineffectual assignment to `err` (ineffassign)
	data, err := ioutil.ReadAll(resp.Body)
	      ^
Error: pkg/credentials/iam_aws_test.go:139:3: S1023: redundant `return` statement (gosimple)
		return
		^
Error: make: *** [Makefile:15: lint] Error 1
Error: Process completed with exit code 2.

@michaelfoley1
Copy link
Contributor Author

@klauspost Sorry about that.
I've fixed any lint/vet issues and force-pushed over my branch (as per the CONTRIBUTING.md file)

@michaelfoley1
Copy link
Contributor Author

@klauspost the tests are failing with the message:

GitHub Actions has encountered an internal error when running your job.

Could you try giving it a kick/retry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants