sts: Always slash expiry time by 80% #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
requested changes
Aug 17, 2021
There was a problem hiding this comment.
I think it would be more reasonable to only use the 80% when the DefaultExpiryWindow is used.
I would keep it, but have it be -1. If the window sent is equal, use 80%.
Don't deprecate it and allow previous behavior to work as expected.
What about also having a default minimum time?
klauspost
reviewed
Aug 17, 2021
vadmeste
force-pushed
the
always-decrease-by-0.8
branch
from
d869e88
to
31ca77e
Compare
klauspost
reviewed
Aug 18, 2021
Currently, STS expiration time is reduced by 10 seconds, but this is not always good since an S3 call can be called near expiration time but evaluated after the expiration time - the window here is 10 seconds which can be not enough to upload some large data to an S3 server before this latter rejects it with bad (expired) credentials. This commit will slash expiration time by 80% instead by default.
vadmeste
force-pushed
the
always-decrease-by-0.8
branch
from
31ca77e
to
db3e9a8
Compare
Co-authored-by: Klaus Post <klauspost@gmail.com>
vadmeste
force-pushed
the
always-decrease-by-0.8
branch
from
cfeb39c
to
2909f1f
Compare
harshavardhana
approved these changes
Aug 18, 2021
klauspost
approved these changes
Aug 19, 2021
vadmeste
pushed a commit
to vadmeste/minio
that referenced
this pull request
Aug 23, 2021
This fixes some issues in replication & S3 gateway: - minio/minio-go#1531 - minio/minio-go#1533
7 tasks
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Aug 24, 2021
This fixes some issues in replication & S3 gateway: - minio/minio-go#1531 - minio/minio-go#1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, STS expiration time is reduced by 10 seconds, but this is
not always good since an S3 call can be called near expiration time but
evaluated after the expiration time - the window here is 10 seconds
which can be not enough to upload some large data to an S3 server before
this latter rejects it with bad (expired) credentials.
This commit will always slash expiration time by 80% instead.