acl: Fix GetObjectACL xml parsing #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Dec 10, 2021
A Recent change introduced a regression in parsing Object ACL S3 API. This issue is not detected by minio-go functional tests since CI only runs it against MinIO where Object ACL is unsupported. Fix the regression and allow short testing of ObjectACL since MinIO supports a small subset of the spec.
harshavardhana
force-pushed
the
fix-get-object-acl
branch
from
db75809
to
47af6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Recent change introduced a regression in parsing Object ACL S3 API.
This issue is not detected by minio-go functional tests since CI only
runs it against MinIO where Object ACL is unsupported.
Fix the regression and allow short testing of ObjectACL since MinIO
supports a small subset of the spec.