Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestMultipartUpload #1645

Merged
merged 1 commit into from
May 25, 2022
Merged

Add TestMultipartUpload #1645

merged 1 commit into from
May 25, 2022

Conversation

zkep
Copy link
Contributor

@zkep zkep commented Apr 27, 2022

Add TestMultipartUpload

harshavardhana
harshavardhana requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are trying to add here that is not covered by existing tests? @zkep

@zkep
Copy link
Contributor Author

zkep commented Apr 27, 2022 •
edited
Loading

what are trying to add here that is not covered by existing tests? @zkep

listObjectParts，PutObjectPart is not covered @harshavardhana

@zkep zkep marked this pull request as draft April 27, 2022 05:36
@zkep zkep marked this pull request as ready for review April 27, 2022 05:39
@zkep zkep marked this pull request as draft April 27, 2022 05:41
@zkep zkep marked this pull request as ready for review April 27, 2022 06:01
@harshavardhana harshavardhana merged commit 8b5b0be into minio:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zkep @harshavardhana