Support detecting region from FIPS URLs #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balasankarc
changed the title
balasankarc
commented
Jun 10, 2022
Signed-off-by: Balasankar 'Balu' C <balu@dravidam.net>
balasankarc
force-pushed
the
support-fips-getregionfromurl
branch
from
8f05ea4
to
ccb390c
Compare
balasankarc
changed the title
|
@harshavardhana Could you please take a look? Thanks. (Apologies if pinging you directly wasn't the right thing to do. I checked the Contributor's guide and couldn't find what I should be doing to request reviews) |
harshavardhana
approved these changes
Jun 10, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var amazonS3HostFIPS = regexp.MustCompile(`^s3-fips.(.*?).amazonaws.com$`) | ||
|
|
||
| // amazonS3HostFIPSDualStack - regular expression used to determine if an arg is s3 FIPS host dualstack. | ||
| var amazonS3HostFIPSDualStack = regexp.MustCompile(`^s3-fips.dualstack.(.*?).amazonaws.com$`) |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames
|
@harshavardhana Thanks a lot for the quick action on this one. Much appreciated. BTW, is a new patch release planned anytime soon? Asking because this issue essentially prevents users from using FIPS endpoints for the GitLab Runner cache - https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29112 |
gitlab-runner-bot
pushed a commit
to gitlabhq/gitlab-runner
that referenced
this pull request
Jun 13, 2022
Previously minio-go did not properly detect the region when AWS FIPS endpoint were used. minio/minio-go#1663 fixes this issue. Relates to https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1662