Avoid unnecessary reopening of HTTP streams in GetObject() #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes consumers of Seek() might use it for purposes other than chaging the current read/write offset. For example, using whence = io.SeekCurrent to get the current seek position. However, minio-go invalidates the underlying HTTP stream unconditionally when Seek() is called, resulting in massive performance degradation in these scenarios. This commit avoids these issues by only reopening the stream if the seek position is actually changed.
harshavardhana
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes consumers of Seek() might use it for purposes other than chaging the current read/write offset. For example, using whence = io.SeekCurrent to get the current seek position. However, minio-go invalidates the underlying HTTP stream unconditionally when Seek() is called, resulting in massive performance degradation in these scenarios.
This commit avoids these issues by only reopening the stream if the seek position is actually changed.
t2bot/matrix-media-repo#516 is an example of such a performance issue resolved by this patch.