api: Retry only request body is seekable #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Sep 20, 2017
api.go
Outdated
| // Retry executes the following function body if request has an | ||
| // error until maxRetries have been exhausted, retry attempts are | ||
| // performed after waiting for a given period of time in a | ||
| // binomial fashion. | ||
| if isRetryable { | ||
| if isSeekable { |
There was a problem hiding this comment.
Why change the variable name? @vadmeste isRetryable is fine here. isSeekable is not providing any meaning. Its also not associated with what this PR tries to fix.
There was a problem hiding this comment.
Why change the variable name? @vadmeste isRetryable is fine here. isSeekable is not providing any meaning. Its also not associated with what this PR tries to fix.
Yeah, it is a simple change, I thought isSeekable is more precise than isRetryable, will revert
api.go
Outdated
| // Retry only when reader is seekable | ||
| reqRetry := MaxRetry | ||
| if !isSeekable { | ||
| reqRetry = 1 |
There was a problem hiding this comment.
We should set this value perhaps in above metadata.contentBody fold itself. Avoids having multiple ifs.
It doesn't make sense to retry a HTTP request when its body is not seekable. Req Body can be delivered by a developer such as in PutObject() API.
harshavardhana
approved these changes
Sep 20, 2017
krisis
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to retry a HTTP request when its body is not
seekable. Req Body can be delivered by a developer such as in
PutObject() API.
Partially fix - ref #791