fix examples in README #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aead, the first example is also missing closing } for main(). Could you fix that as well? |
|
Will do, thanks @poornas |
aead
force-pushed
the
readme_examples
branch
from
5ee4ffb
to
3e006d5
Compare
harshavardhana
requested changes
Sep 19, 2017
README.md
Outdated
| @@ -67,7 +68,7 @@ We will use the Minio server running at [https://play.minio.io:9000](https://pla | |||
| package main | |||
|
|
|||
| import ( | |||
| "github.com/minio/minio-go" | |||
| minio "github.com/minio/minio-go" | |||
There was a problem hiding this comment.
these changes are frivolous we can avoid in this PR.
aead
force-pushed
the
readme_examples
branch
from
3e006d5
to
f7379f9
Compare
The first example is missing a closing breaket. Fixes minio#814
aead
force-pushed
the
readme_examples
branch
from
f7379f9
to
6af7b3e
Compare
harshavardhana
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in the README.md is missing a }.
This change adds it.
Fixes #814