Handle "Not implemented" error codes in functional test #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 3, 2017
functional_tests.go
Outdated
| if strings.Contains(err.Error(), NotImplemented) { | ||
| ignoredLog(function, args, startTime, err.Error()).Info() | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
functional_tests.go
Outdated
| if strings.Contains(err.Error(), NotImplemented) { | ||
| ignoredLog(function, args, startTime, err.Error()).Info() | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
functional_tests.go
Outdated
| if strings.Contains(err.Error(), NotImplemented) { | ||
| ignoredLog(function, args, startTime, err.Error()).Info() | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
functional_tests.go
Outdated
| @@ -62,6 +62,7 @@ const ( | |||
| secretKey = "SECRET_KEY" | |||
| enableHTTPS = "ENABLE_HTTPS" | |||
| ) | |||
| const NotImplemented = "A header you provided implies functionality that is not implemented" | |||
There was a problem hiding this comment.
exported const NotImplemented should have comment or be unexported
kannappanr
force-pushed
the
handle_not_implemented
branch
2 times, most recently
from
b07b9e7
to
d322dca
Compare
|
LGTM |
ebozduman
approved these changes
Oct 3, 2017
harshavardhana
requested changes
Oct 4, 2017
functional_tests.go
Outdated
| @@ -62,6 +62,7 @@ const ( | |||
| secretKey = "SECRET_KEY" | |||
| enableHTTPS = "ENABLE_HTTPS" | |||
| ) | |||
| const notImplemented = "A header you provided implies functionality that is not implemented" | |||
There was a problem hiding this comment.
We don't need to look the string we can simply look for the error code.
functional_tests.go
Outdated
| @@ -4478,6 +4479,10 @@ func testComposeMultipleSources(c *minio.Client) { | |||
| } | |||
| err = c.ComposeObject(dst, srcs) | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), notImplemented) { | |||
There was a problem hiding this comment.
Convert this into a function lets like
isErrNotImplemented()
func isErrNotImplemented(err error) bool {
errResp := ToErrorResponse(err)
return errResp.Code != "NotImplemented"
}
kannappanr
force-pushed
the
handle_not_implemented
branch
3 times, most recently
from
9fd2d9d
to
5a8146b
Compare
harshavardhana
requested changes
Oct 7, 2017
functional_tests.go
Outdated
| @@ -158,6 +158,11 @@ func cleanupBucket(bucketName string, c *minio.Client) error { | |||
| return err | |||
| } | |||
|
|
|||
| func isErrNotImplemented(err error) bool { | |||
| errResp := minio.ToErrorResponse(err) | |||
There was a problem hiding this comment.
This can be written in even one liner..
func isErrNotImplemented(err error) bool {
return minio.ToErrorResponse(err).Code != "NotImplemented"
}
Check for the error message "Not Implemented" in ComposeObject API call. If it is seen, log NA for the test and log the error, but continue with the test. Fixes minio#834
kannappanr
force-pushed
the
handle_not_implemented
branch
from
5a8146b
to
e2bd1cb
Compare
harshavardhana
approved these changes
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the error message "Not Implemented" in ComposeObject
API call. If it is seen, log NA for the test and log the error, but continue
with the test.
Fixes #834