requestMetadata should take the md5 and sha256 with expected encodings. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-core
branch
from
ac2da82
to
a31015c
Compare
|
build fail needs to be addressed. |
harshavardhana
force-pushed
the
fix-core
branch
from
a31015c
to
3093a47
Compare
Fixed @poornas |
harshavardhana
force-pushed
the
fix-core
branch
from
3093a47
to
d0f2bb3
Compare
krisis
requested changes
Oct 24, 2017
api-put-object-streaming.go
Outdated
| // It is to indicate that *minio.Object implements io.ReaderAt. | ||
| // and such a functionality is used in the subsequent code path. | ||
| if isFile(reader) || !isObject(reader) && isReadAt(reader) { | ||
| // Verify if reader is *minio.Object, if yes then use a sequential uploader. |
There was a problem hiding this comment.
The way the comment is split before and after the if-block is confusing. We could have comments describing how we pick sequential or parallel upload strategy in one place.
This is done for readability and also to better communicate the requirements of an API.
harshavardhana
force-pushed
the
fix-core
branch
from
d0f2bb3
to
a1c555f
Compare
krisis
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done for readability and also to better communicate
the requirements of an API.