Update get/setBucketPolicy methods to use files instead of pkg/policy #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
changed the title
nitisht
changed the title
nitisht
force-pushed
the
bucket-policy
branch
2 times, most recently
from
2296d57
to
f4d5fca
Compare
|
Update |
krishnasrinivas
suggested changes
Mar 23, 2018
There was a problem hiding this comment.
@nitisht policy as a string is simpler API than stream, that is how it is done in JS and Py
|
@nitisht, second @krishnasrinivas suggestion on using policy as a string or passed in as a file. |
Also removed ListBucketPolicies API as we move to json file based policy handling. Fixes minio#943
|
updated the PR @harshavardhana @poornas @krishnasrinivas PTAL |
|
@krishnasrinivas could you pls take a look again |
krishnasrinivas
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
ListBucketPoliciesAPI as we move to json file basedpolicy handling.
Fixes #943