Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reading more than 2GiB part data correctly. #1205

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

balamurugana
Copy link
Member

Fixes #1204

Signed-off-by: Bala.FA bala.gluster@gmail.com

@balamurugana balamurugana force-pushed the fix-issue-1204 branch 4 times, most recently from 53e4283 to 44cddc3 Compare June 29, 2021 04:05
Fixes minio#1204

Signed-off-by: Bala.FA <bala.gluster@gmail.com>
anjalshireesh
anjalshireesh previously approved these changes Jul 6, 2021
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion.

api/src/main/java/io/minio/S3Base.java Outdated Show resolved Hide resolved
Signed-off-by: Bala.FA <bala.gluster@gmail.com>
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 24b52bd into minio:master Jul 6, 2021
@balamurugana balamurugana deleted the fix-issue-1204 branch July 6, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle int type cast data loss
3 participants