Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssumeRoleWithCertificate credential provider. #1239

Conversation

balamurugana
Copy link
Member

Signed-off-by: Bala.FA bala@minio.io

sinhaashish
sinhaashish previously approved these changes Oct 6, 2021
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, havent tested it though

anjalshireesh
anjalshireesh previously approved these changes Oct 6, 2021
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

examples/MinioClientWithCertificateIdentityProvider.java Outdated Show resolved Hide resolved
@balamurugana balamurugana force-pushed the Add-AssumeRoleWithCertificate-credential-provider branch from 32383f1 to 43cf75b Compare October 6, 2021 13:02
anjalshireesh
anjalshireesh previously approved these changes Oct 6, 2021
Signed-off-by: Bala.FA <bala@minio.io>
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 898f9c3 into minio:master Oct 8, 2021
@balamurugana balamurugana deleted the Add-AssumeRoleWithCertificate-credential-provider branch October 9, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants