Make Gradle snippet in README compatible with Gradle 7+, Groovy and Kotlin DSLs #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianAigner
force-pushed
the
patch-1
branch
from
b7049c7
to
a956733
Compare
SebastianAigner
changed the title
harshavardhana
approved these changes
Nov 10, 2021
balamurugana
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides Groovy, Gradle also provides support for a Kotlin DSL to configure builds.
To get people running MinIO quickly regardless of the DSL they use, this PR changes the snippet so that it is both valid Groovy syntax and valid Kotlin syntax.
This also changes the
compilekeyword toimplementation, sincecompilehas been deprecated in Gradle 7+.