Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder to removeObjects API #967

Merged
merged 1 commit into from Jun 8, 2020
Merged

add arg builder to removeObjects API #967

merged 1 commit into from Jun 8, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the add-arg-builder-to-removeObjects-API branch 3 times, most recently from cc88d03 to 5bb119e Compare June 4, 2020 16:34
kannappanr
kannappanr previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@balamurugana balamurugana force-pushed the add-arg-builder-to-removeObjects-API branch from 5bb119e to dc221fb Compare June 5, 2020 10:08
kannappanr
kannappanr previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from vadmeste June 6, 2020 16:50
@balamurugana balamurugana force-pushed the add-arg-builder-to-removeObjects-API branch from dc221fb to ddb95ac Compare June 8, 2020 14:05
vadmeste
vadmeste approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@kannappanr kannappanr merged commit 1baff6b into minio:master Jun 8, 2020
@balamurugana balamurugana deleted the add-arg-builder-to-removeObjects-API branch June 9, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@kannappanr kannappanr kannappanr approved these changes

@anjalshireesh anjalshireesh Awaiting requested review from anjalshireesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balamurugana @vadmeste @kannappanr