Fixed issue with closing files in fPutObject() function (#1112)

minio · Apr 26, 2023 · 832ac71 · 832ac71
1 parent 75ed013
commit 832ac71
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/main/minio.js b/src/main/minio.js
@@ -1034,13 +1034,15 @@ export class Client {
       cb => fs.stat(filePath, cb),
       (stats, cb) => {
         size = stats.size
+        var stream
         var cbTriggered = false
         var origCb = cb
         cb = function () {
           if (cbTriggered) {
             return
           }
           cbTriggered = true
+          if (stream) stream.destroy()
           return origCb.apply(this, arguments)
         }
         if (size > this.maxObjectSize) {
@@ -1060,7 +1062,7 @@ export class Client {
             .on('data', data => {
               var md5sum = data.md5sum
               var sha256sum = data.sha256sum
-              var stream = fs.createReadStream(filePath, options)
+              stream = fs.createReadStream(filePath, options)
               uploader(stream, size, sha256sum, md5sum, (err, objInfo) => {
                 callback(err, objInfo)
                 cb(true)
@@ -1095,13 +1097,15 @@ export class Client {
         async.whilst(
           cb => { cb(null, uploadedSize < size) },
           cb => {
+            var stream
             var cbTriggered = false
             var origCb = cb
             cb = function () {
               if (cbTriggered) {
                 return
               }
               cbTriggered = true
+              if (stream) stream.destroy()
               return origCb.apply(this, arguments)
             }
             var part = parts[partNumber]
@@ -1126,7 +1130,7 @@ export class Client {
                   return cb()
                 }
                 // part is not uploaded yet, or md5 mismatch
-                var stream = fs.createReadStream(filePath, options)
+                stream = fs.createReadStream(filePath, options)
                 uploader(uploadId, partNumber, stream, length,
                          data.sha256sum, data.md5sum, (e, objInfo) => {
                            if (e) return cb(e)