Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose single linter, make pass, and make stricter #604

Closed
3 tasks done
brendanashworth opened this issue Jul 6, 2017 · 2 comments · Fixed by #606
Closed
3 tasks done

Choose single linter, make pass, and make stricter #604

brendanashworth opened this issue Jul 6, 2017 · 2 comments · Fixed by #606
Assignees
Milestone

Comments

@brendanashworth
Copy link
Contributor

brendanashworth commented Jul 6, 2017

Right now there are two linters in the project, jscs and jshint. jshint is configured to be lenient and let anything pass (right now, semicolons are optional and show up sometimes, while two-space indentation is preferred but four-space is allowed, etc). jscs is stricter but doesn't match the current code base and as such fails. The following should happen to fix this:

  • pick either jshint or jscs, and run that on npm test
  • select preferred code style for the code base that is stricter
  • adopt changes to code base to follow new code style
@krishnasrinivas
Copy link
Contributor

pick either jshint or jscs, and run that on npm test

can you pick one? mentioning the reasoning behind it?

select preferred code style for the code base that is stricter

we have tried to follow 2 spaces and no semi-colons

adopt changes to code base to follow new code style

Can you send a PR fixing it?

@brendanashworth
Copy link
Contributor Author

@krishnasrinivas sure, thanks for the info. I'll take on the issue then and put in these changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants