Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composeObject error for aws non-versioned bucket #1029

Merged
merged 1 commit into from
May 1, 2022
Merged

Fix composeObject error for aws non-versioned bucket #1029

merged 1 commit into from
May 1, 2022

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Apr 27, 2022 •
edited

Fix composeObject error for aws non-versioned bucket

  • Tested with MinIO

Tested with S3

  • non versioned bucket
  • version enabled bucket

Closes #1026

S3 Error in case of un versioned bucket and no versionId is passed.

ERROR BODY:
{
        "code": "UnknownError",
        "amzRequestid": null,
        "amzId2": null,
        "amzBucketRegion": null
}
REQUEST: HEAD /_100-mb-file-to-test-compose.sf-part2?versionId=

@prakashsvmx prakashsvmx changed the title Fix composeObject error for aws un-versioned bucket Fix composeObject error for aws non-versioned bucket Apr 27, 2022
@prakashsvmx prakashsvmx self-assigned this Apr 27, 2022
ebozduman
ebozduman approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehendricks
Copy link

@prakashsvmx excellent, thanks for the quick fix!

@kannappanr kannappanr merged commit 06e4081 into minio:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@ebozduman ebozduman ebozduman approved these changes

@kannappanr kannappanr kannappanr approved these changes

@kanagarajkm kanagarajkm Awaiting requested review from kanagarajkm

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

composeObject fails for S3 when versionId is empty
5 participants
@prakashsvmx @leehendricks @harshavardhana @ebozduman @kannappanr