fix: honour the set region config

[prakashsvmx]

honour the set region config
fixes #1038

  playConfig= {
    useSSL:false,
    endPoint:"localhost",
    port:9000,
    accessKey:"minio",
    secretKey:"minio123",
    region: "us-west-1  
  }

Test env setup for default region:

//ensure no region is set in minio server
mc admin config set local region name= && mc admin service restart local

export SERVER_ENDPOINT=localhost:9000 && export ACCESS_KEY=minio && export SECRET_KEY=minio123 && npm run functional

 mc admin config set local region name=us-west-1 && mc admin service restart local

export MINIO_REGION="us-west-1" && export SERVER_ENDPOINT=localhost:9000 && export ACCESS_KEY=minio && export SECRET_KEY=minio123 && npm run functional

Test script for APIs

var Minio = require('../../dist/main/minio')
const _ = require("lodash");

let s3Client = new Minio.Client({
  useSSL:false,
  endPoint:"localhost",
  port:9000,
  accessKey:"minio",
  secretKey:"minio123",
  region:"us-west-1"
})

s3Client.traceOn()
/*s3Client.makeBucket("test-new-bucket-e1","", (err, res)=>{
  if(err) {
    console.log(":Err:..", err)
  }
  if (res){
    console.log(".. Done..")
  }
})*/

/*
s3Client.listBuckets((e, buckets) => {
  if (e) {
    console.log("Error....")
  }

  console.log(`Listed:${buckets.length}`)
})*/


var objectsStream = s3Client.listObjects('test-bucket', '', true)
objectsStream.on('data', function(obj) {
  console.log(obj)
})
objectsStream.on('error', function(e) {
  console.log(e)
})

[harshavardhana]

@prakashsvmx I think there may be some bugs that you might have now because the changes look way too much.

Check how minio-py handles this specifically def _get_region - this is what you need in minio-js.

[prakashsvmx]

@harshavardhana thank you. I checked the minio-py and added back the validation i removed in earlier commit.

i have extracted the hard coded default region into a const and replaced all the occurrences
And the functional-tests.js has been formatted

[prakashsvmx]

I have checked the minio-go code. as per the implementation, the make bucket is retried with server returned region in case the region is not configured ("") or default region (us-east-1) on the client.

So i will explore further . marking it as WIP. @harshavardhana @ebozduman @kannappanr

thank you for the guidance.

[ebozduman]

LGTM