Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize build and add typescript support progressively #1114

Closed
wants to merge 6 commits into from

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Apr 4, 2023

use parcel for builds ES module and CommonJS

npm run build

Make sure unit/functional tests are running successfully.

SERVER_ENDPOINT="localhost:22000" ACCESS_KEY="minio" SECRET_KEY="minio123" npm run test

to migrate individual file,
move to ts
apply ts changes
npx lint # only current rules apply once we enable all other rules, it would just be formatting

@prakashsvmx prakashsvmx changed the title Modernize build Modernize build and add typescript support progressively Apr 4, 2023
@trim21
Copy link
Contributor

trim21 commented Apr 9, 2023

I can help rewrite some files to ts if you need.

(need a tsconfig.json before migration)

@prakashsvmx
Copy link
Member Author

@trim21 thank you so much. I will check if tests can be run without issues when migrating to ts. And request for volunteering.

@trim21
Copy link
Contributor

trim21 commented Apr 9, 2023

@trim21 thank you so much. I will check if tests can be run without issues when migrating to ts. And request for volunteering.

I can help imporve workflow to support ts files first, with only migrate errors.js to errors.ts to see if it's working 😀

@prakashsvmx
Copy link
Member Author

Closing this in favour of the merged PR.

@prakashsvmx prakashsvmx closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants