Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: hex parsed as number #1133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed: hex parsed as number #1133

wants to merge 2 commits into from

Conversation

cachalots
Copy link

@cachalots cachalots commented Apr 28, 2023

NaturalIntelligence/fast-xml-parser#536
NaturalIntelligence/fast-xml-parser#513
If I use a hex string as the object name to upload, I will never get the real object name.

@prakashsvmx
Copy link
Member

prakashsvmx commented Apr 28, 2023

Thank you @cachalots 👍

Could you please add some details on the issue and a unit test @cachalots ?

https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html

@cachalots
Copy link
Author

Thank you @cachalots 👍

Could you please add some details on the issue and a unit test @cachalots ?

https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html

I submitted unittest, but I am not a pro js coder, so there may be some problem

@prakashsvmx
Copy link
Member

I will add a functional test for this and we can review/ merge later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants