Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate Credentials CredentialProvider to TypeScript #1138

Merged
merged 9 commits into from May 12, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 5, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review May 5, 2023 08:20
prakashsvmx
prakashsvmx previously approved these changes May 10, 2023
harshavardhana
harshavardhana previously approved these changes May 12, 2023
@trim21
Copy link
Contributor Author

trim21 commented May 12, 2023

didn't resolve merge conflict correctly

@trim21 trim21 requested a review from prakashsvmx May 12, 2023 00:49
@trim21
Copy link
Contributor Author

trim21 commented May 12, 2023

should add sleep after starting minio ...


  1) functional tests
       "before all" hook in "functional tests":
     S3Error: Server not initialized, please try again.
      at Object.parseError (src\/xml-parsers.js:37:11)
      at parser (src\/transformers.js:121:22)
      at Transform._flush (src\/transformers.js:51:12)
      at Transform.prefinish (node_modules\readable-stream\lib\_stream_transform.js:123:10)
      at Transform.emit (node:events:511:28)
      at prefinish (node_modules\readable-stream\lib\_stream_writable.js:569:14)
      at finishMaybe (node_modules\readable-stream\lib\_stream_writable.js:576:5)
      at endWritable (node_modules\readable-stream\lib\_stream_writable.js:594:3)
      at Transform.Writable.end (node_modules\readable-stream\lib\_stream_writable.js:535:22)
      at IncomingMessage.onend (node:internal/streams/readable:713:10)
      at Object.onceWrapper (node:events:625:28)
      at IncomingMessage.emit (node:events:523:35)
      at endReadableNT (node:internal/streams/readable:1367:12)
      at processTicksAndRejections (node:internal/process/task_queues:82:21)

@harshavardhana harshavardhana merged commit 0229893 into minio:master May 12, 2023
14 checks passed
@trim21 trim21 deleted the ts/creds branch May 12, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants