Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate CopyConditions PostPolicy to TypeScript #1141

Merged
merged 9 commits into from May 12, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 5, 2023

We should use typescript type instead of a class as input in the future

@trim21 trim21 marked this pull request as ready for review May 5, 2023 11:04
@trim21 trim21 changed the title refactor: TypeScript CopyConditions refactor: TypeScript CopyConditions and PostPolicy May 12, 2023
@trim21 trim21 changed the title refactor: TypeScript CopyConditions and PostPolicy refactor: migrate CopyConditions and PostPolicy to TypeScrip May 12, 2023
@trim21 trim21 changed the title refactor: migrate CopyConditions and PostPolicy to TypeScrip refactor: migrate CopyConditions and PostPolicy to TypeScript May 12, 2023
@trim21 trim21 changed the title refactor: migrate CopyConditions and PostPolicy to TypeScript refactor: migrate CopyConditions PostPolicy to TypeScript May 12, 2023
@trim21 trim21 marked this pull request as draft May 12, 2023 02:44
@trim21 trim21 marked this pull request as ready for review May 12, 2023 02:44
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM 👍

@harshavardhana harshavardhana merged commit 613932c into minio:master May 12, 2023
14 checks passed
@trim21 trim21 deleted the ts/copy-conditions branch May 12, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants