Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: async internal client request methods to TypeScript #1156

Merged
merged 11 commits into from
May 24, 2023
Merged

refactor: async internal client request methods to TypeScript #1156

merged 11 commits into from
May 24, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 21, 2023

No description provided.

@trim21 trim21 changed the title refactor: async internal request to TypeScript [WIP] refactor: async internal request to TypeScript May 21, 2023
@trim21 trim21 changed the title [WIP] refactor: async internal request to TypeScript refactor: async internal client request methods to TypeScript May 21, 2023
@trim21 trim21 marked this pull request as ready for review May 21, 2023 04:15
@trim21
Copy link
Contributor Author

trim21 commented May 21, 2023

@aldy505 can you help review this PR?

trim21
trim21 commented May 21, 2023
View reviewed changes
src/minio.js Show resolved Hide resolved
aldy505
aldy505 reviewed May 21, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile, I'll re-review this once I'm on my laptop.

src/internal/client.ts Outdated Show resolved Hide resolved
src/internal/client.ts Show resolved Hide resolved
aldy505
aldy505 reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/internal/xml-parser.ts Outdated Show resolved Hide resolved
prakashsvmx
prakashsvmx approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@minio-trusted minio-trusted merged commit 23ad6e2 into minio:master May 24, 2023
14 checks passed
@trim21 trim21 deleted the ts/request branch May 24, 2023 22:29
This was referenced Jun 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trim21 @aldy505 @prakashsvmx @minio-trusted