Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setBucketPolicy #1221

Merged
merged 17 commits into from
Nov 29, 2023
Merged

refactor: setBucketPolicy #1221

merged 17 commits into from
Nov 29, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Oct 31, 2023

No description provided.

@trim21 trim21 marked this pull request as draft November 3, 2023 19:47
@trim21 trim21 closed this Nov 4, 2023
@trim21 trim21 reopened this Nov 14, 2023
src/minio.js Outdated Show resolved Hide resolved
@trim21 trim21 marked this pull request as ready for review November 22, 2023 11:07
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx
Copy link
Member

Please resolve the conflicts. @trim21

@trim21
Copy link
Contributor Author

trim21 commented Nov 28, 2023

@kaankabalak

@kaankabalak kaankabalak self-requested a review November 28, 2023 17:41
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit cbf83dd into minio:master Nov 29, 2023
14 checks passed
trim21 added a commit to trim21/minio-js that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants