Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: getObject and fGetObject #1225

Merged
merged 29 commits into from
Dec 8, 2023
Merged

refactor: getObject and fGetObject #1225

merged 29 commits into from
Dec 8, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Oct 31, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review November 3, 2023 15:36
@trim21 trim21 marked this pull request as draft November 3, 2023 19:47
@trim21 trim21 closed this Nov 4, 2023
@trim21 trim21 reopened this Nov 14, 2023
trim21
trim21 commented Nov 22, 2023
View reviewed changes
docs/zh_CN/API.md Outdated Show resolved Hide resolved
@trim21 trim21 marked this pull request as ready for review November 22, 2023 11:12
@trim21 trim21 changed the title refactor: getObject refactor: getObject and fGetObject Nov 28, 2023
aldy505
aldy505 reviewed Nov 28, 2023
View reviewed changes
src/internal/client.ts Show resolved Hide resolved
src/minio.d.ts Outdated Show resolved Hide resolved
@trim21
Copy link
Contributor Author

trim21 commented Dec 6, 2023

@prakashsvmx

prakashsvmx
prakashsvmx approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@prakashsvmx prakashsvmx mentioned this pull request Dec 7, 2023
Open
@trim21
Copy link
Contributor Author

trim21 commented Dec 7, 2023

@kaankabalak

@prakashsvmx prakashsvmx merged commit 51cf376 into minio:master Dec 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@kaankabalak kaankabalak kaankabalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trim21 @aldy505 @prakashsvmx @kaankabalak