Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: completeMultipartUpload to TypeScript #1229

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 3, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review November 3, 2023 19:42
@trim21 trim21 marked this pull request as draft November 5, 2023 10:01
@trim21 trim21 changed the title refactor: completeMultipartUpload to TypeScript [WIP] refactor: completeMultipartUpload to TypeScript Nov 8, 2023
@trim21 trim21 marked this pull request as ready for review November 14, 2023 03:44
@trim21 trim21 changed the title [WIP] refactor: completeMultipartUpload to TypeScript refactor: completeMultipartUpload to TypeScript Nov 14, 2023
@trim21
Copy link
Contributor Author

trim21 commented Nov 14, 2023

@prakashsvmx /ping

prakashsvmx
prakashsvmx previously approved these changes Nov 17, 2023
@trim21
Copy link
Contributor Author

trim21 commented Nov 18, 2023

merge conflict resolved

@trim21
Copy link
Contributor Author

trim21 commented Nov 20, 2023

@kaankabalak

Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit a7225ff into minio:master Nov 21, 2023
14 checks passed
@trim21 trim21 deleted the completeMultipartUpload branch November 21, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants