Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JavaScript SDK Quickstart #1236

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Conversation

feorlen
Copy link
Contributor

@feorlen feorlen commented Nov 10, 2023

Some small updates so the text better matches Docs style, since this README is imported directly into the web docs.

I made a few changes to the example also, like make it work if the bucket exists. I'm not a great JavaScript person so please let me know the usual style so it makes sense.

I was able to run the example with the latest Node.js, seems like it requires at least v 16. Is that accurate? When I tried with v12.22.9 I got required: { node: '^16 || ^18 || >=20' }.

Corresponding Docs issue minio/docs#1042

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@prakashsvmx
Copy link
Member

We focus on supporting node LTS versions. https://nodejs.org/en/about/previous-releases @feorlen .

@trim21
Copy link
Contributor

trim21 commented Nov 15, 2023

in fact it support down to node v12

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@feorlen
Copy link
Contributor Author

feorlen commented Nov 30, 2023

Finally able to get back to this, it's become a lower priority task for other reasons. But I still need to know something about JS for future work, so worth getting right. Appreciate any additional comments.

@feorlen
Copy link
Contributor Author

feorlen commented Dec 15, 2023

Updated the file-uploader.mjs example in the README, although I don't know where to see the linter's issue with it. The check detail doesn't say.

Are there still needed changes in the examples dir?

@aldy505
Copy link
Contributor

aldy505 commented Dec 18, 2023

@feorlen formatter check is failing, you should do npm run format

Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me.

Pinging @trim21 @prakashsvmx @kaankabalak for review.

kaankabalak
kaankabalak previously approved these changes Dec 18, 2023
README.md Outdated Show resolved Hide resolved
@feorlen
Copy link
Contributor Author

feorlen commented Dec 18, 2023

Looks like I installed prettier correctly yay. One small fix, update branch, maybe this is good now. 🎉

Appreciate the guidance getting through this!

@prakashsvmx prakashsvmx merged commit 46532ac into minio:master Dec 19, 2023
14 checks passed
@feorlen feorlen deleted the DOCS-1042 branch December 19, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants