Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor bucket lifecycle apis to ts #1276

Merged
merged 2 commits into from
Apr 11, 2024
Merged

refactor bucket lifecycle apis to ts #1276

merged 2 commits into from
Apr 11, 2024

Conversation

prakashsvmx
Copy link
Member

refactor
setBucketLifecycle
getBucketLifecycle
removeBucketLifecycle

apis to typescript.

@prakashsvmx prakashsvmx self-assigned this Apr 5, 2024
@prakashsvmx prakashsvmx marked this pull request as draft April 5, 2024 08:06
@prakashsvmx prakashsvmx marked this pull request as ready for review April 5, 2024 09:33
kaankabalak
kaankabalak reviewed Apr 10, 2024
View reviewed changes
src/internal/client.ts Outdated Show resolved Hide resolved
kaankabalak
kaankabalak approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@kaankabalak kaankabalak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a very small note: Seems like the commit title exceeds the 72 character limit, would it be possible to edit that before merging?

@prakashsvmx prakashsvmx changed the title refactorsetBucketLifecycle getBucketLifecycle removeBucketLifecycle to ts refactor bucket lifecycle apis to ts Apr 11, 2024
@prakashsvmx prakashsvmx merged commit b5a8d3f into minio:master Apr 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaankabalak kaankabalak kaankabalak approved these changes

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prakashsvmx @kaankabalak