Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multipart upload with keepalive memory leak #811

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix multipart upload with keepalive memory leak #811

merged 1 commit into from
Dec 23, 2019

Conversation

sberthier
Copy link
Contributor

  • Socket were not released by each uploaded part http request.
  • When using http agent with keepalive, each request were still referenced through sockets and indirectly reference chunk data.

@RaboliotLeGris
Copy link

Hi!

I'm interested with this fix too! Any news ?

kaankabalak
kaankabalak previously approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is looking good to me, we can also work on the multipart test optimization issue on another PR.

@sberthier sberthier force-pushed the fix/multipart-upload-with-keepalive branch from 7402769 to 47e2a1f Compare December 23, 2019 15:29
@sberthier
Fix multipart upload with keepalive memory leak
fd68d13 
- Socket were not released by each uploaded part http request.
- When using http agent with keepalive, each request were still
  referenced through sockets and indirectly reference chunk data.
@sberthier sberthier force-pushed the fix/multipart-upload-with-keepalive branch from 47e2a1f to fd68d13 Compare December 23, 2019 16:15
@kannappanr kannappanr merged commit 2ee6b3c into minio:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaankabalak kaankabalak kaankabalak approved these changes

@kanagarajkm kanagarajkm kanagarajkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sberthier @RaboliotLeGris @kaankabalak @kanagarajkm @kannappanr