Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get set bucket versioning #891

Merged
merged 7 commits into from Jan 24, 2021
Merged

Get set bucket versioning #891

merged 7 commits into from Jan 24, 2021

Conversation

prakashsvmx
Copy link
Member

Set and Get Bucket versioning

@prakashsvmx prakashsvmx self-assigned this Jan 5, 2021
ebozduman
ebozduman requested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes seem to be missing in ./README.md and in ./docs/API.md.
Please update these 2 documents.

examples/get-bucket-versioning.js Show resolved Hide resolved
examples/put-bucket-versioning.js Outdated Show resolved Hide resolved
examples/get-bucket-versioning.js Show resolved Hide resolved
src/main/minio.js Outdated Show resolved Hide resolved
src/main/minio.js Outdated Show resolved Hide resolved
@prakashsvmx prakashsvmx dismissed a stale review via e326bd2 January 13, 2021 12:01
@prakashsvmx
Copy link
Member Author

@ebozduman Thank you for the review. I have addressed the review comments. PTAL

ebozduman
ebozduman requested changes Jan 14, 2021
View reviewed changes
src/main/transformers.js Outdated Show resolved Hide resolved
src/main/xml-parsers.js Outdated Show resolved Hide resolved
docs/API.md Show resolved Hide resolved
@prakashsvmx prakashsvmx mentioned this pull request Jan 15, 2021
Closed
1 task
@minio minio deleted a comment from prakashsvmx Jan 15, 2021
ebozduman
ebozduman reviewed Jan 15, 2021
View reviewed changes
src/main/minio.js Outdated Show resolved Hide resolved
ebozduman
ebozduman previously approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebozduman
ebozduman approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 3f62bb4 into minio:master Jan 24, 2021
@prakashsvmx prakashsvmx deleted the get-set-bucket-versioning branch February 10, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@kannappanr kannappanr kannappanr approved these changes

@kanagarajkm kanagarajkm Awaiting requested review from kanagarajkm

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prakashsvmx @ebozduman @kannappanr