-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minio 7.2.1 requires urllib3>=2.0 #1378
Comments
Feel free to send a PR |
@balamurugana Do you prefer to add |
@ydc-0 |
7.2.0 was still working without issues and just now our pipelines are breaking due to these urllib3 errors. I don't understand why this breaking change was introduced with a patch version in https://github.com/minio/minio-py/releases/tag/7.2.1 If I'm not missing something then just adding |
What is the error you are getting? |
We're having this issue as well. I'd really suggest that we add support for urllib 1 and 2 instead of forcing the v2 version just because of typing.. I'll try to find the time to submit a PR for this. |
I investigated a little further: The only issue is the import of This class was added in
What do you think is the way to go @balamurugana @mwagnurr @ydc-0 ? |
@anehx I suggest to use |
@anehx In fact, I'm still using BTW,
|
@balamurugana Is it possible to avoid pip install If |
Issue
minio 7.2.1 can not work with urllib3 1.x, but
urllib3>2.0
is not ininstall_requires
.Since urllib3 2.0 is less than one year, There are still some other packages that do not support urllib3 2.x. It would be better if minio is still compatible with urllib3 1.x.
https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#200-2023-04-26
https://github.com/minio/minio-py/pull/1367/files
To reproduce
Failure Logs
The text was updated successfully, but these errors were encountered: