Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getbytes() usage in make_bucket() API #1073

Merged
merged 1 commit into from
Jan 29, 2021
Merged

fix getbytes() usage in make_bucket() API #1073

merged 1 commit into from
Jan 29, 2021

Conversation

balamurugana
Copy link
Member

Fixes #1072

@balamurugana balamurugana mentioned this pull request Jan 27, 2021
Closed
krisis
krisis previously approved these changes Jan 27, 2021
View reviewed changes
ebozduman
ebozduman previously approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana dismissed stale reviews from ebozduman and krisis via 860e1b5 January 28, 2021 06:02
voegtlel
voegtlel approved these changes Jan 28, 2021
View reviewed changes
Copy link

@voegtlel voegtlel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes the issue :)

ebozduman
ebozduman approved these changes Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 014651b into minio:master Jan 29, 2021
@balamurugana balamurugana deleted the fix-issue-1072 branch January 29, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voegtlel voegtlel voegtlel approved these changes

@ebozduman ebozduman ebozduman approved these changes

@kannappanr kannappanr kannappanr approved these changes

@krisis krisis krisis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make_bucket raises AttributeError toxml
6 participants
@balamurugana @krisis @voegtlel @ebozduman @kannappanr @harshavardhana