Fix upload snowball objects with staging file #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable length must be set for method fput_object not to use multipart.
balamurugana
requested changes
Jun 27, 2023
tests/functional/tests.py
Outdated
| @@ -1891,6 +1891,32 @@ def test_upload_snowball_objects(log_entry): | |||
| _CLIENT.remove_object(bucket_name, "my-object3") | |||
| _CLIENT.remove_bucket(bucket_name) | |||
|
|
|||
| # run with staging file option | |||
There was a problem hiding this comment.
Have def _test_upload_snowball_objects(log_entry, staging_filename): and use the method to have two tests named test_upload_snowball_objects() and test_upload_snowball_objects_staging_file to avoid code duplication.
tests/functional/tests.py
Outdated
| mod_time=datetime.now(), | ||
| ), | ||
| ], | ||
| staging_filename="staging.tar" |
There was a problem hiding this comment.
Use random filename here like f"{uuid4()}.tar"
balamurugana
requested changes
Jun 27, 2023
tests/functional/tests.py
Outdated
| _test_upload_snowball_objects(log_entry) | ||
|
|
||
|
|
||
| def test_upload_snowball_objects_with_staging(log_entry): |
There was a problem hiding this comment.
Add in-line comment # pylint: disable=invalid-name to ignore this pylint error.
balamurugana
approved these changes
Jun 29, 2023
harshavardhana
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in upload_snowball_objects when it is called with "staging_filename" parameter. The variable "length" passed to fput_object is not defined in this case.