XML Parsing refactor: #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
donatello
force-pushed
the
xml_pro
branch
2 times, most recently
from
fe7ba6d
to
f4c45cd
Compare
Adds new S3 aware parser helper class S3Element: - Captures commonly performed S3 related parsing actions - Is namespace aware - Eliminate usage of large repetitive constants - Easy to use and has lead to significant simplication of code Fixes minio#432.
balamurugana
approved these changes
Dec 20, 2016
harshavardhana
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new S3 aware parser helper class S3Element:
Fixes #432.