Custom certificate bundles #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s users to provide their own certificate bundle. One example use case scenario would be if a user wanted to provide a self signed certificate to use with their Minio object. If the user doesn\'t provide a certificate bundle themselves, Minio will default to using certifi\'s certificate bundle.
removed them from my previous commit
harshavardhana
requested changes
Mar 18, 2017
minio/api.py
Outdated
| @@ -119,7 +119,8 @@ class Minio(object): | |||
| def __init__(self, endpoint, access_key=None, | |||
| secret_key=None, secure=True, | |||
| region=None, | |||
| timeout=None): | |||
| timeout=None, | |||
| certificate_bundle=certifi.where()): | |||
harshavardhana
approved these changes
Mar 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter to the Minio class initialization method that allows users to provide their own certificate bundle. One example use case scenario would be if a user wanted to provide a self signed certificate to use with their Minio object. If the user doesn't provide a certificate bundle themselves, Minio will default to using Certifi's (certifi.where()) certificate bundle.