Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add easy-access methods to PostPolicy #596

Merged
merged 2 commits into from Nov 28, 2017
Merged

add easy-access methods to PostPolicy #596

merged 2 commits into from Nov 28, 2017

Conversation

boyxuper
Copy link
Contributor

@boyxuper boyxuper commented Nov 21, 2017 •
edited

changes:

  • Add PostPolicy.append_policy for easy-accessing
  • Keep post policy untouched while applying to Minio.presigned_post_policy

@deekoder deekoder requested review from balamurugana, poornas and kannappanr and removed request for balamurugana November 22, 2017 00:37
poornas
poornas requested changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boyxuper , could you separate the PEP8 changes into a separate PR and leave only the PostPolicy changes in this one?

@boyxuper
Copy link
Contributor Author

boyxuper commented Nov 22, 2017 •
edited

okay, @poornas it's done

@nitisht
Copy link
Contributor

nitisht commented Nov 28, 2017

@kannappanr can you please take a look

kannappanr
kannappanr approved these changes Nov 28, 2017
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit b59ff17 into minio:master Nov 28, 2017
@boyxuper boyxuper deleted the policy-easy-access branch November 28, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boyxuper @nitisht @poornas @kannappanr