Cleanup incomplete upload upon error #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannappanr
reviewed
Dec 7, 2017
minio/api.py
Outdated
| @@ -1524,7 +1524,8 @@ def _stream_put_object(self, bucket_name, object_name, | |||
|
|
|||
| part_data = read_full(data, current_part_size) | |||
| # Append current part information | |||
| parts_to_upload.append((bucket_name, object_name, upload_id, part_number, part_data)) | |||
| parts_to_upload.append((bucket_name, object_name, upload_id, | |||
There was a problem hiding this comment.
Is this just a formatting change?
vadmeste
reviewed
Dec 7, 2017
minio/api.py
Outdated
| @@ -1524,7 +1524,8 @@ def _stream_put_object(self, bucket_name, object_name, | |||
|
|
|||
| part_data = read_full(data, current_part_size) | |||
| # Append current part information | |||
| parts_to_upload.append((bucket_name, object_name, upload_id, part_number, part_data)) | |||
| parts_to_upload.append((bucket_name, object_name, upload_id, | |||
| part_number, part_data)) | |||
|
|
|||
| # Run parts upload in parallel | |||
| pool.parallel_run(self._upload_part_routine, parts_to_upload) | |||
There was a problem hiding this comment.
pool.parallel_run() can raise an exception, I think it would be good to catch it, remove incomplete upload and throw the exception again.
try:
pool.parallel_run(self._upload_part_routine, parts_to_upload)
except:
self._remove_incomplete_upload(bucket_name,
object_name,
upload_id)
raise
harshavardhana
force-pushed
the
pool
branch
2 times, most recently
from
67e2c50
to
1255abe
Compare
vadmeste
reviewed
Dec 7, 2017
minio/api.py
Outdated
| self._remove_incomplete_upload(bucket_name, | ||
| object_name, | ||
| upload_id) | ||
|
|
Since we do not have resuming support, we should simply cleanup failed transfers.
kannappanr
reviewed
Dec 7, 2017
| upload_id, | ||
| uploaded_parts, | ||
| metadata=metadata) | ||
| try: |
There was a problem hiding this comment.
Looks like there is formatting issue here
There was a problem hiding this comment.
i don't see any issue, if there is a formatting issue python won't really compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do not have resuming support, we should
simply cleanup failed transfers.