Adds missing tests and fixes tests with problems #609
Conversation
| @@ -1208,7 +1208,6 @@ def remove_incomplete_upload(self, bucket_name, object_name): | |||
| if object_name == upload.object_name: | |||
| self._remove_incomplete_upload(bucket_name, object_name, | |||
| upload.upload_id) | |||
| return | |||
| client.make_bucket(bucket_name) | ||
| # Check if bucket was created properly | ||
| log_output.function = 'bucket_exists(bucket_name)' |
There was a problem hiding this comment.
Isn't it little confusing to change function name multiple times in the same test function ? I thought log_output.function should represent the name of the function.
There was a problem hiding this comment.
It is the name of the API being tested
There was a problem hiding this comment.
If you check the end of tests.py file (starting with line#1555), you'll notice, we first create an instance of LogOutput class, log_output, and we initialize its function attribute with the name of the api command/method that will go under test.
For example, in the above test case "test_make_bucket_default_region", log_output.function is set to "make_bucket(bucket_name, location)". This is the default value and the same logic is used for all test cases.
Because some tests, like "test_make_bucket_default_region", depend on some other helper api commands, it would be misleading to report a helper api command,"bucket_exists" in our case, failure with the name of the api command, "make_bucket" in our case, under test. That's why, I set log_output.function to "bucket_exists(bucket_name)" before calling "bucket_exists" api/helper command and change it to the later helper api command, if one is called in the next step, "remove_bucket" in our case. This way, the name of the failed api command will be reflected correctly in the generated Json format output in the function field. If everything goes well, then we set the function field back to the name of the api command under test before reporting a "PASS" status for the test.
Since the code is not clear, (@vadmeste and I exchanged ideas on Slack and we agreed on) it would be helpful to have comments that explain the default value of log_output.function for each test case.
There was a problem hiding this comment.
Done and squashed.
There was a problem hiding this comment.
we can simplify the code in another PR
ebozduman
force-pushed
the
add_missing_tests
branch
from
5216874
to
3120973
Compare
Fixes #562